Add cardinality control for groupby benchs with flat types #15134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointKernel
added
feature request
|
Thanks for kicking this off! You might also consider adding nvbench axes for cardinality for the existing benchmarks. If we started with a default value of |
PointKernel
changed the title
PointKernel
changed the title
PointKernel
added
3 - Ready for Review
ttnghia
reviewed
Mar 5, 2024
Comment on lines
+46
to
+50
| data_profile profile = | ||
| data_profile_builder() | ||
| .cardinality(cardinality) | ||
| .no_validity() | ||
| .distribution(cudf::type_to_id<int32_t>(), distribution_id::UNIFORM, 0, size); |
There was a problem hiding this comment.
Code to create keys and values here seem to be very similar (the same) as for creating those of groupby max. Can we further extract them into a common function? Like create_keys_values()?
There was a problem hiding this comment.
The duplicate part is just data profile construction. Though we repeat those 5 lines of code each time, it's just one API call. It's not worth creating a helper function wrapping one single call IMO.
ttnghia
approved these changes
Mar 5, 2024
vyasr
approved these changes
Mar 8, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to #15114
This PR adds cardinality control to
group_max,group_nuniqueandgroup_rankbenchmarks.Checklist