Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove const from range_window_bounds::_extent. #15138

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Remove const from range_window_bounds::_extent. #15138

merged 2 commits into from
Feb 26, 2024

Conversation

mythrocks
Copy link
Contributor

@mythrocks mythrocks commented Feb 24, 2024 •
edited
Loading

Fixes #15131.

Description

The const on the _extent member of range_window_bounds is superfluous. It provides no additional protection to range_window_bounds's invariants, and prevents the class from being copy assignable.

This change removes the const, thus making range_window_bounds copy-assignable, and more readily usable from Cython.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mythrocks
Remove const from range_window_bounds::_extent.
3342102 
Fixes rapidsai#15131.

The `const` on the `_extent` member of `range_window_bounds` is superfluous.
It provides no additional protection to `range_window_bounds`'s invariants,
and prevents the class from being copy assignable.
@mythrocks mythrocks requested a review from a team as a code owner February 24, 2024 01:23
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 24, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@mythrocks mythrocks self-assigned this Feb 24, 2024
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Feb 24, 2024
@mythrocks mythrocks added bug Something isn't working non-breaking Non-breaking change and removed libcudf Affects libcudf (C++/CUDA) code. labels Feb 24, 2024
@mythrocks
Copy link
Contributor Author

/ok to test

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Feb 24, 2024
@mythrocks
Copy link
Contributor Author

/ok to test

1 similar comment
@mythrocks
Copy link
Contributor Author

/ok to test

@mythrocks
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 7d2da0e into rapidsai:branch-24.04 Feb 26, 2024
69 checks passed
@mythrocks
Copy link
Contributor Author

Thank you for reviewing, chaps. This change is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@davidwendt davidwendt davidwendt approved these changes

@robertmaynard robertmaynard Awaiting requested review from robertmaynard robertmaynard is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@vuule vuule Awaiting requested review from vuule vuule is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@mythrocks mythrocks

Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change range_window_bounds to support copy-assignment
3 participants
@mythrocks @ttnghia @davidwendt