-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround compute-sanitizer memcheck bug #15259
Merged
rapids-bot
merged 5 commits into
rapidsai:branch-24.04
from
davidwendt:sanitizer-workaround
Mar 11, 2024
Merged
Workaround compute-sanitizer memcheck bug #15259
rapids-bot
merged 5 commits into
rapidsai:branch-24.04
from
davidwendt:sanitizer-workaround
Mar 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
bug
Something isn't working
3 - Ready for Review
Ready for review by team
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
labels
Mar 8, 2024
bdice
approved these changes
Mar 10, 2024
vyasr
approved these changes
Mar 11, 2024
AyodeAwe
approved these changes
Mar 11, 2024
/merge |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
Enables tests disable in #15259 due to a `compute-sanitizer` bug. This has been fixed in the CUDA 12.5 release and the nightly memchecks should pass again with these enabled. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Nghia Truong (https://github.com/ttnghia) - Bradley Dice (https://github.com/bdice) URL: #16581
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
bug
Something isn't working
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provides a workaround for the compute-sanitizer issue described in #15258 causing memcheck failures in nightly builds.
An environment variable is introduced
LIBCUDF_MEMCHECK_ENABLED
so test code can bypass specific tests that cause the compute-sanitizer error. The env var is set only during memcheck tests since the failure does not occur in normal testing.The failure only occurs for some
int16
oruint16
reduction tests so managing these few tests is reasonable.Other possible workarounds include
Using the latest version is more desirable since the fix will likely not be back ported.
This disables checking for almost all reduction kernels
Checklist