Enable test-reporting for pandas pytests in CI #15369
Conversation
galipremsagar
added
improvement
| MAIN_ARTIFACT=$(rapids-s3-path)cuda12_$(arch)_py310.main-results.json | ||
| PR_ARTIFACT=$(rapids-s3-path)cuda12_$(arch)_py310.pr-results.json | ||
| aws s3 cp $MAIN_ARTIFACT main-results.json | ||
| PR_ARTIFACT=$(rapids-s3-path)cuda12_$(arch)_py39.pr-results.json |
There was a problem hiding this comment.
The python version changed and is different from the main artifact. Is that expected?
Also, why not use Python 3.11?
There was a problem hiding this comment.
answered here: #15485 (comment)
There seems to be no python 3.11 for cuda-12.2 pull-request build type.
| MAIN_ARTIFACT=$(rapids-s3-path)cuda12_$(arch)_py310.main-results.json | ||
| PR_ARTIFACT=$(rapids-s3-path)cuda12_$(arch)_py310.pr-results.json | ||
| aws s3 cp $MAIN_ARTIFACT main-results.json | ||
| PR_ARTIFACT=$(rapids-s3-path)cuda12_$(arch)_py39.pr-results.json |
There was a problem hiding this comment.
It would be better if these versions were not hard coded if possible.
If that can't be accomplished easily, please file an issue for it but extract the values to variables defined prominently in the beginning of the file.
There was a problem hiding this comment.
I don't think that would still work here, the actual job that generates the json files is different from the job that runs this file, so we wouldn't be able to utilize the machine's versions here.
|
|
||
| rapids-logger "Fetching latest available results from nightly" | ||
| aws s3api list-objects-v2 --bucket rapids-downloads --prefix "nightly/" --query "sort_by(Contents[?ends_with(Key, '.main-results.json')], &LastModified)[::-1].[Key]" --output text > s3_output.txt | ||
| cat s3_output.txt |
There was a problem hiding this comment.
This is printed by the logger on line 18
| PR_ARTIFACT=$(rapids-s3-path)cuda12_$(arch)_py39.pr-results.json | ||
|
|
||
| rapids-logger "Fetching latest available results from nightly" | ||
| aws s3api list-objects-v2 --bucket rapids-downloads --prefix "nightly/" --query "sort_by(Contents[?ends_with(Key, '.main-results.json')], &LastModified)[::-1].[Key]" --output text > s3_output.txt |
There was a problem hiding this comment.
Maybe this logic should be moved to gha-tools since it relies on the paths created there.
Co-authored-by: Ray Douglass <3107146+raydouglass@users.noreply.github.com>
There was a problem hiding this comment.
Talked with @galipremsagar and I will approve to unblock things, but Prem will address some of my feedback in a follow up PR.
…gar/cudf into pandas_test_reporting
|
/merge |
Follow-up PR: #15485 |
This PR fixes an issue where `listJobsForWorkflowRun` returns only 30 jobs details by default and we need to paginate and load the rest all of the job details to be able to filter jobs. This PR also address review comments in #15369 Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - Ray Douglass (https://github.com/raydouglass) URL: #15485
Description
This PR enables pandas test-reporting for pandas pytests in CI by comparing against the results available in nightlies as a baseline.
Checklist