Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix maxima of categorical column #15701

Merged
merged 5 commits into from
May 10, 2024
Merged

Fix maxima of categorical column #15701

merged 5 commits into from
May 10, 2024

Conversation

rjzamora
Copy link
Member

@rjzamora rjzamora commented May 8, 2024

Closes #15641

Applies patch suggested by @wence-

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rjzamora rjzamora added bug Something isn't working 2 - In Progress Currently a work in progress non-breaking Non-breaking change labels May 8, 2024
@rjzamora rjzamora self-assigned this May 8, 2024
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 8, 2024
@rjzamora rjzamora mentioned this pull request May 8, 2024
Closed
@rjzamora rjzamora marked this pull request as ready for review May 8, 2024 16:12
@rjzamora rjzamora requested a review from a team as a code owner May 8, 2024 16:12
@rjzamora rjzamora requested review from wence- and galipremsagar May 8, 2024 16:12
@rjzamora rjzamora added 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond and removed 2 - In Progress Currently a work in progress 3 - Ready for Review Ready for review by team labels May 8, 2024
@rjzamora rjzamora mentioned this pull request May 9, 2024
Open
28 tasks
@rjzamora rjzamora added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 4 - Needs Review Waiting for reviewer to review or respond labels May 10, 2024
@rjzamora
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit e93782f into rapidsai:branch-24.06 May 10, 2024
70 checks passed
@rjzamora rjzamora deleted the fix-cat-maxima branch May 10, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@rjzamora rjzamora

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Cannot find maxima of a categorical series
3 participants
@rjzamora @wence- @galipremsagar