Deprecate Groupby.collect
#15808
Merged
Deprecate Groupby.collect
#15808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
improvement
mroeschke
approved these changes
May 21, 2024
rjzamora
reviewed
May 21, 2024
There was a problem hiding this comment.
Thanks @galipremsagar
Good to know that agg(list) is now available in cudf. We will need to make changes to the new (dask-expr) API to deprecate "collect".
|
@galipremsagar - Just pushed a few changes that will hopefully get legacy and expr APIs both working. |
Thanks @rjzamora !! |
rjzamora
approved these changes
May 22, 2024
|
/merge |
galipremsagar
added
the
5 - Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After we made our groupby fail more aggressively for unsupported types in #15712,
Groupby.collectstarted to fail on string column, where this isn't a supported aggregation on string column in pandas and this method doesn't exist in pandas Groupby, hence this PR suggest the alternative equivalent and deprecates the API to be removed in next release.Checklist