Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix convert_dtypes with convert_integer=False/convert_floating=True #15964

Merged
merged 8 commits into from
Jul 15, 2024
Merged

Fix convert_dtypes with convert_integer=False/convert_floating=True #15964

merged 8 commits into from
Jul 15, 2024

Conversation

mroeschke
Copy link
Contributor

Description

If convert_integer=False, there should be no attempt to convert to integer

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 10, 2024
@mroeschke mroeschke requested a review from a team as a code owner June 10, 2024 22:57
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jun 10, 2024
@mroeschke mroeschke removed the improvement Improvement / enhancement to an existing function label Jun 11, 2024
@vyasr
Copy link
Contributor

vyasr commented Jun 24, 2024

@galipremsagar are you happy with this PR? I see that you merged latest a couple of times, not sure if you meant to approve.

@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 04330f2 into rapidsai:branch-24.08 Jul 15, 2024
79 checks passed
@mroeschke mroeschke deleted the bug/convert_dtypes branch July 15, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @vyasr @galipremsagar