Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the pool size alignment issue #16024

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Fix the pool size alignment issue #16024

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
52385d3
Fix the pool size alignment issue
PointKernel Jun 13, 2024
5ff7ad9
cleanup: use CUDA alignment instead
PointKernel Jun 13, 2024
2d16cea
Move roundup logic to the pool mr ctor
PointKernel Jun 13, 2024
bff9aa8
Formatting
PointKernel Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions cpp/src/utilities/pinned_memory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,11 @@ class fixed_pinned_pool_memory_resource {

public:
fixed_pinned_pool_memory_resource(size_t size)
: pool_size_{size}, pool_{new host_pooled_mr(upstream_mr_, size, size)}
: // rmm requires the pool size to be a multiple of 256 bytes
pool_size_{rmm::align_up(size, rmm::CUDA_ALLOCATION_ALIGNMENT)},
pool_{new host_pooled_mr(upstream_mr_, pool_size_, pool_size_)}
{
if (pool_size_ == 0) { return; }
CUDF_LOG_INFO("Pinned pool size = {}", pool_size_);

// Allocate full size from the pinned pool to figure out the beginning and end address
pool_begin_ = pool_->allocate_async(pool_size_, stream_);
Expand Down Expand Up @@ -145,12 +147,8 @@ CUDF_EXPORT rmm::host_device_async_resource_ref& make_default_pinned_mr(
return std::min(total / 200, size_t{100} * 1024 * 1024);
}();

// rmm requires the pool size to be a multiple of 256 bytes
auto const aligned_size = rmm::align_up(size, rmm::RMM_DEFAULT_HOST_ALIGNMENT);
CUDF_LOG_INFO("Pinned pool size = {}", aligned_size);

// make the pool with max size equal to the initial size
return fixed_pinned_pool_memory_resource{aligned_size};
return fixed_pinned_pool_memory_resource{size};
}();

static rmm::host_device_async_resource_ref mr_ref{mr};
Expand Down
Loading