Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cudf::strings::replace_multiple hang on empty target #16167

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Fix cudf::strings::replace_multiple hang on empty target #16167

merged 1 commit into from
Jul 5, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Fixes logic in cudf::strings::replace_multiple to ignore empty targets correctly in the replace_multi_fn functor.
Also updated the doxygen and added a gtest for this case.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Jul 2, 2024
@davidwendt davidwendt self-assigned this Jul 2, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jul 2, 2024
@davidwendt davidwendt marked this pull request as ready for review July 2, 2024 16:55
@davidwendt davidwendt requested a review from a team as a code owner July 2, 2024 16:55
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit a583c97 into rapidsai:branch-24.08 Jul 5, 2024
76 checks passed
@davidwendt davidwendt deleted the fix-multi-repl-hang branch July 5, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@ttnghia ttnghia ttnghia approved these changes

@hyperbolic2346 hyperbolic2346 Awaiting requested review from hyperbolic2346 hyperbolic2346 is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@srinivasyadav18 srinivasyadav18 Awaiting requested review from srinivasyadav18 srinivasyadav18 is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @bdice @ttnghia