Fix parquet_field_list read_func lambda capture of invalid this pointer - moved to 24.08 in PR 16440

[davidwendt]

Description

Moved to #16440

Checklist

• I am familiar with the Contributing Guidelines.
• New or existing tests cover these changes.
• The documentation is up to date with these changes.

[davidwendt]

This illustrates the std::make_tuple pattern mentioned in the description.
https://godbolt.org/z/38onx783o
Note the reader_fn line prints a this pointer value that has already been destroyed 4 lines above this line.

[robertmaynard]

I think we should target 24.08 for this fix

[GregoryKimball]

@etseidl would you please take a look?

[cryos]

It would be great to target 24.08 for this, just testing now. Thanks @davidwendt!

[cryos]

This fixes all unit tests when applied in my local GCC 12 build. The test case I was using also passes when rebuilt against this patched GCC 12 build. Just rebuilding the more complete test case but at first glance this completely resolves the issue I reported. The changes look reasonable to me too. Thanks once again.

[etseidl]

Looks good to me. Nice save @davidwendt!

[davidwendt]

Moved to #16440