-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix all-empty input column for strings split APIs #16466
Merged
rapids-bot
merged 9 commits into
rapidsai:branch-24.10
from
davidwendt:fix-split-record
Aug 13, 2024
Merged
Fix all-empty input column for strings split APIs #16466
rapids-bot
merged 9 commits into
rapidsai:branch-24.10
from
davidwendt:fix-split-record
Aug 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
bug
Something isn't working
2 - In Progress
Currently a work in progress
libcudf
Affects libcudf (C++/CUDA) code.
strings
strings issues (C++ and Python)
non-breaking
Non-breaking change
labels
Aug 1, 2024
davidwendt
added
3 - Ready for Review
Ready for review by team
and removed
2 - In Progress
Currently a work in progress
labels
Aug 9, 2024
davidwendt
changed the title
[WIP] Fix all-empty input column for strings split APIs
Fix all-empty input column for strings split APIs
Aug 9, 2024
davidwendt
requested review from
mroeschke,
lithomas1,
harrism and
hyperbolic2346
August 9, 2024 17:21
harrism
approved these changes
Aug 12, 2024
bdice
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to verify — this aligns with pandas behavior, but what about Spark? Code looks fine otherwise.
Spark integration tests (after reverting workaround for empty strings due to issue #16453) all passed with this work 👍 |
hyperbolic2346
approved these changes
Aug 13, 2024
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
bug
Something isn't working
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Python
Affects Python cuDF API.
strings
strings issues (C++ and Python)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes specialized behavior for all empty input column on the strings split APIs.
Verifying behavior with Pandas
str.split( pat, expand, regex )
pat=None -- whitespace
expand=False -- record APIs
regex=True -- re APIs
split
split
- whitespacersplit
rsplit
- whitespacesplit_record
split_record
- whitespacersplit_record
rsplit_record
- whitespacesplit_re
rsplit_re
split_record_re
rsplit_record_re
Closes #16453
Checklist