Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure size is always passed to NumericalColumn #16576

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Ensure size is always passed to NumericalColumn #16576

merged 2 commits into from
Aug 16, 2024

Conversation

mroeschke
Copy link
Contributor

Description

#16457 requires NumericalColumn to be constructed with size. It appears another PR got in after this PR was created so there are currently a few usages where size isn't passed in.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 16, 2024
@mroeschke mroeschke requested a review from a team as a code owner August 16, 2024 01:03
@mroeschke mroeschke requested review from Matt711 and lithomas1 August 16, 2024 01:03
@vyasr vyasr mentioned this pull request Aug 16, 2024
Merged
12 tasks
vyasr
vyasr approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! I wasn't sure if most of those cases the column could be passed directly without creating a new one, nice to see that that does work.

python/cudf/cudf/core/column/column.py Show resolved Hide resolved
@vyasr vyasr mentioned this pull request Aug 16, 2024
Merged
3 tasks
@vyasr
Copy link
Contributor

vyasr commented Aug 16, 2024

Looks like there are a few more places not caught by mypy that are turning up in the test suite.

@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit e690d9d into rapidsai:branch-24.10 Aug 16, 2024
70 checks passed
@mroeschke mroeschke deleted the fix/numericalcolumn/size branch August 16, 2024 17:31
@mroeschke mroeschke mentioned this pull request Aug 16, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@vyasr vyasr vyasr approved these changes

@Matt711 Matt711 Awaiting requested review from Matt711 Matt711 is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@lithomas1 lithomas1 Awaiting requested review from lithomas1 lithomas1 is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @vyasr @galipremsagar