Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slowdown in DataFrame repr in jupyter notebook #16656

Merged
merged 25 commits into from
Aug 28, 2024

Conversation

galipremsagar
Copy link
Contributor

Description

Fixes: #15747

This PR fixes slow-down in DataFrame repr inside a jupyter notebook.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working non-breaking Non-breaking change labels Aug 26, 2024
@galipremsagar galipremsagar self-assigned this Aug 26, 2024
@galipremsagar galipremsagar requested a review from a team as a code owner August 26, 2024 16:14
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added Python Affects Python cuDF API. cudf.pandas Issues specific to cudf.pandas labels Aug 26, 2024
@galipremsagar galipremsagar requested a review from a team as a code owner August 26, 2024 16:18
@galipremsagar galipremsagar requested a review from a team as a code owner August 27, 2024 17:54
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Copy link
Contributor

@Matt711 Matt711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes LGTM. I checked that the dataframe in the original issue "hangs" for me without the _ipython_canary_method_should_not_exist_ method raising an AttributeError and doesn't hang when it does. Do you why that is?

Also, do we need to something similar for pd.Series?

@galipremsagar
Copy link
Contributor Author

These changes LGTM. I checked that the dataframe in the original issue "hangs" for me without the _ipython_canary_method_should_not_exist_ method raising an AttributeError and doesn't hang when it does. Do you why that is?

It is because of this: #16656 (comment)

Also, do we need to something similar for pd.Series?

Nope, Series doesn't have a repr_html, and doesn't seem to have the hangs either.

@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 569939f into rapidsai:branch-24.10 Aug 28, 2024
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cudf.pandas Issues specific to cudf.pandas non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] cudf.pandas dataframe.__repr__ slow in jupyterlab for large datasets
4 participants