Update patches for CCCL 2.6 #16668
Open
Update patches for CCCL 2.6 #16668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… due to code changes in thrust. This adopts those patches to apply with CCCL 2.6. Should only be merged when updating the CCCL version
github-actions
bot
added
libcudf
miscco
commented
Aug 27, 2024
| + status = call arguments; \ | ||
| + } \ | ||
| + else \ | ||
| + { \ | ||
| + throw std::runtime_error("THRUST_INDEX_TYPE_DISPATCH 64-bit count is unsupported in libcudf"); \ |
There was a problem hiding this comment.
Our formatter did some crazy things here, so that the patches are less localized. Shout if you need them to be minimal
|
Better yet would be to just nuke these patches. I believe we can do that once these two CCCL issues are done:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adopts the patches to thrust to apply with CCCL 2.6.
Should only be merged when updating the CCCL version, but I am opening them now to not forget it and then accidentally drop them