Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle ordered parameter in CategoricalIndex.__repr__ #16683

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Handle ordered parameter in CategoricalIndex.__repr__ #16683

merged 2 commits into from
Aug 29, 2024

Conversation

galipremsagar
Copy link
Contributor

Description

Thanks @mroeschke for catching this in #16665 (comment)

This PR factors in the ordered parameter while generating the repr for CategoricalIndex.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working non-breaking Non-breaking change labels Aug 28, 2024
@galipremsagar galipremsagar self-assigned this Aug 28, 2024
@galipremsagar galipremsagar requested a review from a team as a code owner August 28, 2024 21:02
@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 28, 2024
@galipremsagar galipremsagar mentioned this pull request Aug 28, 2024
Merged
3 tasks
@galipremsagar
Copy link
Contributor Author

/merge

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Aug 28, 2024
@rapids-bot rapids-bot bot merged commit f6e2355 into rapidsai:branch-24.10 Aug 29, 2024
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@Matt711 Matt711 Awaiting requested review from Matt711 Matt711 is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galipremsagar @mroeschke