Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable gtests/ERROR_TEST during compute-sanitizer memcheck test #16691

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Disable gtests/ERROR_TEST during compute-sanitizer memcheck test #16691

merged 1 commit into from
Aug 29, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Disables the gtests/ERROR_TEST when run under compute-sanitizer for memcheck. The compute-sanitizer started hanging on some of these tests. There is no value in running memcheck on any of the tests in ERROR_TEST

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Aug 29, 2024
@davidwendt davidwendt self-assigned this Aug 29, 2024
@davidwendt davidwendt requested a review from a team as a code owner August 29, 2024 13:42
@pmattione-nvidia
Copy link
Contributor

Do we know why it started hanging?

@davidwendt
Copy link
Contributor Author

Do we know why it started hanging?

Not yet. Looking into it now.

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit eca5108 into rapidsai:branch-24.10 Aug 29, 2024
86 checks passed
@davidwendt davidwendt deleted the memcheck-error-test branch August 29, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@pmattione-nvidia pmattione-nvidia pmattione-nvidia approved these changes

@hyperbolic2346 hyperbolic2346 Awaiting requested review from hyperbolic2346 hyperbolic2346 is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @pmattione-nvidia @bdice