Add labeling APIs to pylibcudf #16761
Conversation
mroeschke
added
improvement
github-actions
bot
added
Python
| ctypedef enum inclusive: | ||
| YES "cudf::inclusive::YES" | ||
| NO "cudf::inclusive::NO" | ||
| cpdef enum class inclusive(bool): |
There was a problem hiding this comment.
Should this enum be exposed in the public API according to https://docs.rapids.ai/api/cudf/stable/developer_guide/pylibcudf/#cython-scoped-enums?
There was a problem hiding this comment.
Yes. Note also that the cudf::inclusive enum has an underlying type of int, not bool.
| cpdef enum class inclusive(bool): | |
| cpdef enum class inclusive(int): |
Arguably that should be changed on the C++ side, although if we do that, we should change the order of the definition. So that bool(cudf::inclusive::YES) is true.
| ctypedef enum inclusive: | ||
| YES "cudf::inclusive::YES" | ||
| NO "cudf::inclusive::NO" | ||
| cpdef enum class inclusive(bool): |
There was a problem hiding this comment.
Yes. Note also that the cudf::inclusive enum has an underlying type of int, not bool.
| cpdef enum class inclusive(bool): | |
| cpdef enum class inclusive(int): |
Arguably that should be changed on the C++ side, although if we do that, we should change the order of the definition. So that bool(cudf::inclusive::YES) is true.
Co-authored-by: Lawrence Mitchell <wence@gmx.li>
|
/merge |
Follow up to #16761, I forgot to add the doc pages for the labeling pylibcudf APIs Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Matthew Murray (https://github.com/Matt711) URL: #16779
Description
Contributes to #15162
Checklist