Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cudf::strings::findall error with empty input #16928

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Fix cudf::strings::findall error with empty input #16928

merged 1 commit into from
Sep 26, 2024

Conversation

davidwendt
Copy link
Contributor

Fixes cudf::strings::findall error when passed an empty input column.
Also adds a gtest for empty input and for all-rows do not match case.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) non-breaking Non-breaking change labels Sep 26, 2024
@davidwendt davidwendt self-assigned this Sep 26, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Sep 26, 2024
@davidwendt davidwendt marked this pull request as ready for review September 26, 2024 15:56
@davidwendt davidwendt requested a review from a team as a code owner September 26, 2024 15:56
@vyasr
Copy link
Contributor

vyasr commented Sep 26, 2024

/merge

@rapids-bot rapids-bot bot merged commit fa12901 into rapidsai:branch-24.12 Sep 26, 2024
100 checks passed
@davidwendt davidwendt deleted the findall-empty-input branch September 26, 2024 23:11
copy-pr-bot bot pushed a commit that referenced this pull request Sep 28, 2024
@davidwendt @lamarrr
Fix cudf::strings::findall error with empty input (#16928)
39f40d5 
Fixes `cudf::strings::findall` error when passed an empty input column.
Also adds a gtest for empty input and for all-rows do not match case.

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Yunsong Wang (https://github.com/PointKernel)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #16928
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@PointKernel PointKernel PointKernel approved these changes

@shrshi shrshi Awaiting requested review from shrshi shrshi is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @vyasr @PointKernel