Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switched BINARY_OP Benchmarks from GoogleBench to NVBench #16963

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Switched BINARY_OP Benchmarks from GoogleBench to NVBench #16963

merged 4 commits into from
Oct 4, 2024

Conversation

lamarrr
Copy link
Contributor

@lamarrr lamarrr commented Oct 1, 2024

Description

This merge request switches the Benchmarking solution for the BINARY_OP benchmarks from GoogleBench to NVBench

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@lamarrr lamarrr requested a review from a team as a code owner October 1, 2024 15:57
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Oct 1, 2024
@lamarrr lamarrr added non-breaking Non-breaking change feature request New feature or request and removed libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Oct 1, 2024
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Oct 2, 2024
kingcrimsontianyu
kingcrimsontianyu approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@kingcrimsontianyu kingcrimsontianyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Thanks!

@lamarrr
Copy link
Contributor Author

lamarrr commented Oct 4, 2024

/merge

@rapids-bot rapids-bot bot merged commit a784321 into rapidsai:branch-24.12 Oct 4, 2024
99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@kingcrimsontianyu kingcrimsontianyu kingcrimsontianyu approved these changes

@karthikeyann karthikeyann Awaiting requested review from karthikeyann karthikeyann is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees
No one assigned
Labels
CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lamarrr @ttnghia @kingcrimsontianyu