Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regex handling of fixed quantifier with 0 range #17067

Open
wants to merge 3 commits into
base: branch-24.12
Choose a base branch
from
Open

Fix regex handling of fixed quantifier with 0 range #17067

wants to merge 3 commits into from
+64 −4

Conversation

davidwendt
Copy link
Contributor

Description

Fixes regex logic handling of a pattern with a fixed quantifier that includes a zero-range.
Added new gtests for this specific case.
Bug was introduced in #16798

Closes #17065

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) non-breaking Non-breaking change labels Oct 11, 2024
@davidwendt davidwendt self-assigned this Oct 11, 2024
@davidwendt davidwendt requested a review from a team as a code owner October 11, 2024 17:51
revans2
revans2 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the tests pass after this.

Thanks for the really quick fix.

This was referenced Oct 14, 2024
Open
Merged
vyasr
vyasr approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well this is fun. Nice find Bobby. Out of curiosity: these are certainly valid regexes, but is there a good reason to use them?

mythrocks
mythrocks approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this on Friday, and neglected to 👍 it.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@revans2 revans2 revans2 approved these changes

@mythrocks mythrocks mythrocks approved these changes

@lamarrr lamarrr lamarrr approved these changes

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] 0 range regexp appear to be broken
5 participants
@davidwendt @vyasr @revans2 @mythrocks @lamarrr