[HOTFIX] Overload for atomicAdd on int64 #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
split the file into `device_atomics.cuh` and `device_operators.cuh` separated the difinition of the device operators
move atomicCASImpl(int8 or int16) into typesAtomicCASImpl
simplify atomicMin, atomixMax add cudf::bool8 for atomic test case for atomicAdd,Min,Max add cudf::bool8 specialization for genericAtomicOperation
Add '__forceinline__ __device__' to `W genericAtomicOperator(W)`
Add size check assert between `long long int` and `int64_t`
remove redundant `sizeof(T)` when calling 'typesAtomicCASImpl`
remove redundant `sizeof(T)` when calling 'genericAtomicOperationImpl`
Add native atomicAdd(uint64_t) call for sint64_t
Add comment for `genericAtomicOperationImpl<int64_t, DeviceSum, 8>` why it uses atomicAdd(uint64) inside
Removed `genericAtomicOperation(W)` since it is not invoked for cudf::wrapper types. Merged it into `genericAtomicOperation(T)` Add size check assert at `type_reinterpret`.
jrhemstad
added
libcudf
kkraus14
reviewed
May 14, 2019
Co-Authored-By: Keith Kraus <keith.j.kraus@gmail.com>
kkraus14
approved these changes
May 14, 2019
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1691
Because #1691 was based off of branch-0.8, I had to cherry-pick it's commits onto a new branch based off of release-0.7.2.
In order to hotfix the abysmal performance of groupby when summing int64, provides an overload for atomicAdd
int64that simply casts touint64. Because 2s complement is used, this is safe.https://en.wikipedia.org/wiki/Two%27s_complement