Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support numba-cuda>=0.0.18 #17359

Open
wants to merge 5 commits into
base: branch-25.02
Choose a base branch
from

Conversation

brandon-b-miller
Copy link
Contributor

This PR changes the way that cuDF puts numba into MVC mode for CUDA 12, using an env var rather than by applying a runtime patch to numba.

@brandon-b-miller brandon-b-miller requested review from a team as code owners November 18, 2024 22:03
@github-actions github-actions bot added the Python Affects Python cuDF API. label Nov 18, 2024
@brandon-b-miller
Copy link
Contributor Author

This is not strictly necessary for 24.12.

@@ -196,7 +195,7 @@ class Aggregation:
# Handling UDF type
nb_type = numpy_support.from_dtype(kwargs['dtype'])
type_signature = (nb_type[:],)
ptx_code, output_dtype = cudautils.compile_udf(op, type_signature)
ptx_code, output_dtype = cudf.utils.cudautils.compile_udf(op, type_signature)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config setting needs to be in place before numba.cuda is imported, which otherwise happens here during cython import

@brandon-b-miller brandon-b-miller added feature request New feature or request non-breaking Non-breaking change labels Nov 18, 2024
@vyasr vyasr changed the base branch from branch-24.12 to branch-25.02 November 20, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant