-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create pylibcudf.Column
from a column_view
and an arbitrary owning object
#17543
Draft
Matt711
wants to merge
18
commits into
rapidsai:branch-25.02
Choose a base branch
from
Matt711:plc/17040
base: branch-25.02
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
a918700
Create pylibcudf.Column from a column_view and an arbitrary owning ob…
Matt711 e15c991
Merge branch 'branch-25.02' into plc/17040
Matt711 0171d97
type cast object to Column
Matt711 24586dc
data and null_mask are not properties of plc.Column
Matt711 7eb1009
get the pointer from the tuple
Matt711 f56ae99
Merge branch 'branch-25.02' into plc/17040
Matt711 c506cbc
get data and mask from cai
Matt711 c732fd3
use plc from_column_view
Matt711 ffdd19c
Merge branch 'branch-25.02' into plc/17040
Matt711 3ec624c
lint
Matt711 35b185b
narrow the check
Matt711 2405350
Merge branch 'branch-25.02' into plc/17040
Matt711 84e63ff
Merge branch 'branch-25.02' into plc/17040
Matt711 eaf2459
plumb through from_table_view and plc.contiguous_split.unpack
Matt711 1530b2b
call cudf::unpack on owner
Matt711 fdc1217
Merge branch 'branch-25.02' into plc/17040
Matt711 ddeab78
try transferring ownership
Matt711 eae7f6b
Merge branch 'branch-25.02' into plc/17040
Matt711 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can default a fused typed argument to
None