Bump Polars version to <1.18 #17632
Open
Bump Polars version to <1.18 #17632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt711
added
improvement
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
github-actions
bot
added
Python
|
/ok to test |
Matt711
changed the title
mroeschke
reviewed
Dec 19, 2024
mroeschke
reviewed
Dec 19, 2024
wence-
reviewed
Dec 20, 2024
dependencies.yaml
Outdated
| @@ -747,7 +747,7 @@ dependencies: | |||
| common: | |||
| - output_types: [conda, requirements, pyproject] | |||
| packages: | |||
| - polars>=1.11,<1.15 | |||
| - polars>=1.11,<1.17 | |||
There was a problem hiding this comment.
can we support polars 1.17.1 (the latest release)? with <1.18
Matt711
commented
Dec 20, 2024
|
It looks like we also need an IR version bump. |
Matt711
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades the Polars version to 1.17. It also xfails some polars tests.
In polars, floor division by 0 returns None whereas we return 255 (max value of uint8)
But we
Checklist