Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement .dt.total_seconds #17659

Open
wants to merge 8 commits into
base: branch-25.02
Choose a base branch
from
Open

Implement .dt.total_seconds #17659

wants to merge 8 commits into from
+98 −7

Conversation

galipremsagar
Copy link
Contributor

Description

Fixes: #16802

This PR implements .dt.total_seconds

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 26, 2024
@galipremsagar galipremsagar self-assigned this Dec 26, 2024
@galipremsagar galipremsagar requested a review from a team as a code owner December 26, 2024 19:56
@github-actions github-actions bot added the Python Affects Python cuDF API. label Dec 26, 2024
galipremsagar and others added 3 commits December 30, 2024 16:23
@galipremsagar @mroeschke
Update python/cudf/cudf/core/index.py
ab08fe2 
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
@galipremsagar
fix type annotation
82d70a2
@galipremsagar
minor cleanup
8e836e1
@galipremsagar
Copy link
Contributor Author

/merge

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] dt.total_seconds
2 participants
@galipremsagar @mroeschke