Add support for writing ORC with map columns #9369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fea-orc-map-write
…fea-orc-map-write
…fea-orc-map-write
github-actions
bot
added
Python
vuule
added
feature request
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9369 +/- ##
================================================
- Coverage 10.79% 10.75% -0.04%
================================================
Files 116 116
Lines 18869 19482 +613
================================================
+ Hits 2036 2096 +60
- Misses 16833 17386 +553
Continue to review full report at Codecov.
|
…fea-orc-map-write
…fea-orc-map-write
vuule
requested review from
vyasr,
devavret,
brandon-b-miller and
rgsl888prabhu
…fea-orc-map-write
devavret
approved these changes
Oct 7, 2021
galipremsagar
approved these changes
Oct 7, 2021
rgsl888prabhu
approved these changes
Oct 7, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8826
Users can mark a list column as a map and ORC writer will write it into the output file as such.
Also removed some redundant code in Python tests, completely unrelated to the feature.