Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement mixed equality/conditional joins #9917

Merged

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Dec 16, 2021

This PR implements mixed equality/inequality joins for inner, left, and full joins. This resolves #9696 and contributes to #5401. For the moment, all APIs are functional only, but an object-oriented API is planned to support caching of the hash table.

vyasr added 30 commits December 13, 2021 13:16
…ted overhead to the purely conditional join code paths.
@vyasr vyasr requested review from PointKernel and jrhemstad January 6, 2022 23:29
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cpp/include/cudf/join.hpp Outdated Show resolved Hide resolved
@jrhemstad
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e4a16ae into rapidsai:branch-22.02 Jan 18, 2022
rapids-bot bot pushed a commit that referenced this pull request Jan 19, 2022
Depends on #9917.  Adds Java bindings for the libcudf mixed join APIs.  A new MixedJoinSize class was added to track the size information returned for mixed joins.

Authors:
  - Jason Lowe (https://github.com/jlowe)

Approvers:
  - Robert (Bobby) Evans (https://github.com/revans2)

URL: #9941
rapids-bot bot pushed a commit that referenced this pull request Jan 24, 2022
This PR is a follow-up to #9917 and should be merged after that PR. This resolves #9695 and resolves #5401. The implementation here is only a first pass, but in the interest of prioritizing a working feature for the upcoming release I'm postponing making various additional changes (including some breaking ones).

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Jason Lowe (https://github.com/jlowe)
  - David Wendt (https://github.com/davidwendt)
  - Robert Maynard (https://github.com/robertmaynard)

URL: #10037
@vyasr vyasr deleted the feature/mixed_equality_conditional_joins branch March 9, 2022 17:22
@vyasr vyasr restored the feature/mixed_equality_conditional_joins branch March 9, 2022 17:22
@vyasr vyasr deleted the feature/mixed_equality_conditional_joins branch March 9, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Conditional hash join for inner joins
5 participants