Prune workflows based on changed files #4634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only run tests based on things that have actually changed. For example, if only Python files have changed, we don't need to run the C++ tests. Contributes to rapidsai/build-planning#94
KyleFromNVIDIA
added
improvement
KyleFromNVIDIA
commented
Aug 27, 2024
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
acostadon
reviewed
Aug 31, 2024
jameslamb
reviewed
Sep 20, 2024
jameslamb
reviewed
Sep 20, 2024
There was a problem hiding this comment.
I'm not up to date on the changed-files work, so my review shouldn't count towards a merge. I left one other comment for your consideration.
I'll get caught up today and could leave a more thoughtful review later today, if you still don't have a ci-codeowners approval by then.
robertmaynard
approved these changes
Sep 30, 2024
AyodeAwe
approved these changes
Oct 1, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only run tests based on things that have actually changed. For example, if only Python files have changed, we don't need to run the C++ tests.
Contributes to rapidsai/build-planning#94
Depends on rapidsai/shared-workflows#239