Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] LightGBM 3 not working with FIL #2795

Closed
JohnZed opened this issue Sep 3, 2020 · 4 comments · Fixed by #3316
Closed

[BUG] LightGBM 3 not working with FIL #2795

JohnZed opened this issue Sep 3, 2020 · 4 comments · Fixed by #3316
Labels
bug Something isn't working

Comments

@JohnZed
Copy link
Contributor

JohnZed commented Sep 3, 2020

We have worked around this with PR #2787 , but LightGBM 3 appears to not be working with FIL. Should triage and see if we can add back support (possibly a treelite issue)?
@JohnZed JohnZed added bug Something isn't working ? - Needs Triage Need team to review and classify labels Sep 3, 2020
@JohnZed
Copy link
Contributor Author

JohnZed commented Sep 10, 2020

Possibly related to float64 support for treelite? dmlc/treelite#198

@wphicks
Copy link
Contributor

wphicks commented Sep 18, 2020

@hcho3 Can you confirm that dmlc/treelite#198 is related and/or might address this? If not I'll triage further myself.

@hcho3
Copy link
Contributor

hcho3 commented Sep 18, 2020

Yes, dmlc/treelite#198 will address the issue. See discussion in #2799

@wphicks wphicks removed the ? - Needs Triage Need team to review and classify label Sep 18, 2020
@dantegd
Copy link
Member

dantegd commented Sep 28, 2020

Issue probably will be moved to 0.17

@hcho3 hcho3 mentioned this issue Dec 30, 2020
Merged
8 tasks
@rapids-bot rapids-bot bot closed this as completed in #3316 Jan 7, 2021
rapids-bot bot pushed a commit that referenced this issue Jan 7, 2021
@hcho3
Upgrade Treelite module(#3316)
b8e71ca 
Depends on dmlc/treelite#235, dmlc/treelite#236, dmlc/treelite#237, dmlc/treelite#240, dmlc/treelite#241, dmlc/treelite#242, dmlc/treelite#243

Depends on rapidsai/integration#201

Closes #2160
Closes #2795
Closes #2817

TODOs
- [x] Get code review for dmlc/treelite#235 and dmlc/treelite#236 and merge them
- [x]  Get code review for dmlc/treelite#237 and merge them
- [x] Merge dmlc/treelite#240, dmlc/treelite#241, dmlc/treelite#242, dmlc/treelite#243
- [x] Run tests locally
- [x] Tag a new version of Treelite
- [x] Release a new Conda package with the new version tag
- [x] Update `meta.yml` and the integration package to use the new Treelite
- [x] Run tests (this time build with new Conda package)

Authors:
  - Hyunsu Cho <chohyu01@cs.washington.edu>

Approvers:
  - AJ Schmidt (@ajschmidt8)
  - William Hicks (@wphicks)
  - John Zedlewski (@JohnZed)

URL: #3316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade Treelite module hcho3/cuml
4 participants
@JohnZed @dantegd @hcho3 @wphicks