Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] CUDA lineinfo and kernel info is not generated by current cmake build #3938

Closed
vinaydes opened this issue Jun 3, 2021 · 1 comment · Fixed by #3941
Closed

[BUG] CUDA lineinfo and kernel info is not generated by current cmake build #3938

vinaydes opened this issue Jun 3, 2021 · 1 comment · Fixed by #3941
Assignees
Labels
? - Needs Triage Need team to review and classify bug Something isn't working

Comments

@vinaydes
Copy link
Contributor

vinaydes commented Jun 3, 2021

Describe the bug
cpp/CMakeLists.txt has a option to enable generation of CUDA kernel lineinfo on line:

option(LINE_INFO "Enable lineinfo in nvcc" OFF)

However, enabling it does not generate required lineinfo, which is useful for debugging and profiling.

UPDATE: KERNEL_INFO flag is also ignored, see Venkat's comment below.

Steps/Code to reproduce bug
Enable LINE_INFO option in the CMakeLists.txt file and build in verbose mode. See that CUDA compile lines have no -lineinfo option.

Expected behavior
Line information should be generated when enabled.

Environment details (please complete the following information):

  • Environment location: I tested on Bare-metal, but should be reproducible on Docker, Cloud etc.
  • Linux Distro/Architecture: Not relevant
  • GPU Model/Driver: Not relevant
  • CUDA: Not relevant
  • Method of cuDF & cuML install: from source
    • cmake version 3.20.2 & gcc/g++ version 9.3.2

Additional context
This issue is probably because the module

if(CUDA_ENABLE_LINEINFO)
Looks for variable CUDA_ENABLE_LINEINFO and cpp/CMakeLists.txt sets LINE_INFO. On my local setup changing this produced the line information.

@vinaydes vinaydes added ? - Needs Triage Need team to review and classify bug Something isn't working labels Jun 3, 2021
@venkywonka
Copy link
Contributor

venkywonka commented Jun 3, 2021

I see the same problem with KERNEL_INFO here

option(KERNEL_INFO "Enable kernel resource usage info" OFF)

The only other place that the variable KERNEL_INFO semems to be used in the file is here:

message(VERBOSE "CUML: Enabling kernel resource usage info: ${KERNEL_INFO}")

@vinaydes vinaydes changed the title [BUG] CUDA lineinfo is not generated by current cmake build [BUG] CUDA lineinfo and kernel info is not generated by current cmake build Jun 3, 2021
@dantegd dantegd self-assigned this Jun 7, 2021
@rapids-bot rapids-bot bot closed this as completed in #3941 Jun 9, 2021
rapids-bot bot pushed a commit that referenced this issue Jun 9, 2021
Closes #3938

Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #3941
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this issue Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants