Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] shap explainer npermutations is documented wrongly #4047

Closed
pseudotensor opened this issue Jul 12, 2021 · 2 comments · Fixed by #4402
Closed

[DOC] shap explainer npermutations is documented wrongly #4047

pseudotensor opened this issue Jul 12, 2021 · 2 comments · Fixed by #4402
Assignees
@dantegd
Labels
? - Needs Triage Need team to review and classify doc Documentation inactive-90d

Comments

@pseudotensor
Copy link

says The l1 regularization to use for feature selection which is not right.

https://docs.rapids.ai/api/cuml/nightly/api.html#model-explainability

https://shap-lrjball.readthedocs.io/en/latest/generated/shap.PermutationExplainer.html
@pseudotensor pseudotensor added ? - Needs Triage Need team to review and classify doc Documentation labels Jul 12, 2021
@dantegd dantegd self-assigned this Jul 12, 2021
@dantegd
Copy link
Member

dantegd commented Jul 12, 2021

Thanks for noticing! While re-reading I noticed a few other things that need updating there, so will fix them this week.

@github-actions
Copy link

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@hcho3 hcho3 mentioned this issue Nov 24, 2021
Merged
@rapids-bot rapids-bot bot closed this as completed in #4402 Dec 6, 2021
rapids-bot bot pushed a commit that referenced this issue Dec 6, 2021
@hcho3
Fix docstring for npermutations in PermutationExplainer (#4402)
3c36f62 
Closes #4047

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #4402
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this issue Oct 9, 2023
@hcho3
Fix docstring for npermutations in PermutationExplainer (rapidsai#4402)
ab2990d 
Closes rapidsai#4047

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dantegd dantegd

Labels
? - Needs Triage Need team to review and classify doc Documentation inactive-90d
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix docstring for npermutations in PermutationExplainer hcho3/cuml
2 participants
@dantegd @pseudotensor