Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QST] Do we actually need several points for inference? #4704

Closed
whymauri opened this issue Apr 21, 2022 · 1 comment
Closed

[QST] Do we actually need several points for inference? #4704

whymauri opened this issue Apr 21, 2022 · 1 comment
Assignees
@viclafargue
Labels
bug Something isn't working inactive-30d

Comments

@whymauri
Copy link

What is your question?
These lines:

https://github.com/rapidsai/cuml/blob/3f54aec/python/cuml/manifold/umap.pyx#L735

        if n_rows <= 1:
            raise ValueError("There needs to be more than 1 sample to "
                             "build nearest the neighbors graph")

Do they also apply to the inference case where there is only one point to project? Assuming a pretrained UMAP model .
@whymauri whymauri added ? - Needs Triage Need team to review and classify question Further information is requested labels Apr 21, 2022
@whymauri whymauri changed the title [QST] [QST] Do we actually need several points for inference? Apr 21, 2022
@divyegala divyegala added bug Something isn't working and removed ? - Needs Triage Need team to review and classify question Further information is requested labels Apr 25, 2022
@viclafargue viclafargue mentioned this issue Apr 27, 2022
Merged
rapids-bot bot pushed a commit that referenced this issue May 24, 2022
@viclafargue
Expose simplicial set functions (#4711)
ee0f42e 
This PR closes issues #3123, #4704 and #4292

Authors:
  - Victor Lafargue (https://github.com/viclafargue)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #4711
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@cjnolet cjnolet closed this as completed Jun 6, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this issue Oct 9, 2023
@viclafargue
Expose simplicial set functions (rapidsai#4711)
dcc0068 
This PR closes issues rapidsai#3123, rapidsai#4704 and rapidsai#4292

Authors:
  - Victor Lafargue (https://github.com/viclafargue)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: rapidsai#4711
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viclafargue viclafargue

Labels
bug Something isn't working inactive-30d
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cjnolet @viclafargue @divyegala @whymauri