Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW]Distributed TF-IDF transformer #2698

Merged
merged 23 commits into from
Aug 28, 2020
Merged

[REVIEW]Distributed TF-IDF transformer #2698

merged 23 commits into from
Aug 28, 2020

Conversation

VibhuJawa
Copy link
Member

@VibhuJawa VibhuJawa commented Aug 14, 2020 •
edited
Loading

This pr closes #2598 .

After this PR, we should be able to use this in distributed TF-IDF Pipe-Lines. (HashingVectorizer+TF-IDF Transformer)

See Gist for working examples.

Todo:

CC: @randerzander

@VibhuJawa VibhuJawa requested a review from a team as a code owner August 14, 2020 21:57
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@VibhuJawa VibhuJawa changed the title [WIP]Distributed TF-IDF transformer[Skip-CI] [WIP]Distributed TF-IDF transformer[skip cI] Aug 17, 2020
@VibhuJawa VibhuJawa changed the title [WIP]Distributed TF-IDF transformer[skip cI] [WIP]Distributed TF-IDF transformer[skip ci] Aug 17, 2020
@VibhuJawa VibhuJawa changed the title [WIP]Distributed TF-IDF transformer[skip ci] [REVIEW]Distributed TF-IDF transformer[skip ci] Aug 17, 2020
@VibhuJawa VibhuJawa requested a review from a team as a code owner August 17, 2020 19:26
@VibhuJawa VibhuJawa changed the base branch from branch-0.15 to branch-0.16 August 17, 2020 19:27
@VibhuJawa VibhuJawa changed the title [REVIEW]Distributed TF-IDF transformer[skip ci] [REVIEW]Distributed TF-IDF transformer Aug 17, 2020
@VibhuJawa
Copy link
Member Author

rerun tests.

@VibhuJawa
Copy link
Member Author

This is now ready for a first review. CC: @cjnolet / @dantegd

@cjnolet cjnolet self-assigned this Aug 22, 2020
@cjnolet cjnolet added 3 - Ready for Review Ready for review by team Cython / Python Cython or Python issue Multi-GPU Issues & PRs related to multi-GPU functionality New Algorithm For tracking new algorithms that will be added to our existing collection labels Aug 22, 2020
cjnolet
cjnolet requested changes Aug 27, 2020
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Very minor things.

python/cuml/feature_extraction/_tfidf.py Show resolved Hide resolved
python/cuml/feature_extraction/_tfidf.py Outdated Show resolved Hide resolved
python/cuml/test/conftest.py Outdated Show resolved Hide resolved
python/cuml/feature_extraction/_tfidf.py Outdated Show resolved Hide resolved
python/cuml/dask/feature_extraction/text/tfidf_transformer.py Show resolved Hide resolved
@VibhuJawa @cjnolet
Apply suggestions from code review
e3bbbde 
Fix typos from code reviews.

Co-authored-by: Corey J. Nolet <cjnolet@users.noreply.github.com>
@VibhuJawa VibhuJawa changed the title [REVIEW]Distributed TF-IDF transformer [WIP]Distributed TF-IDF transformer Aug 27, 2020
@VibhuJawa VibhuJawa changed the title [WIP]Distributed TF-IDF transformer [REVIEW]Distributed TF-IDF transformer Aug 27, 2020
@VibhuJawa
Copy link
Member Author

@cjnolet , Have addressed all reviews apart from this one as it seems to be working.

Will update it if needed based on directions. Should be good for a final pass I think now.

@VibhuJawa
Copy link
Member Author

Rerun Tests.

@VibhuJawa
Copy link
Member Author

@cjnolet, This should be good to go now. :-)

cjnolet
cjnolet approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cjnolet cjnolet merged commit 147f795 into rapidsai:branch-0.16 Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd left review comments

@cjnolet cjnolet cjnolet approved these changes

@raydouglass raydouglass raydouglass approved these changes

Assignees

@cjnolet cjnolet

Labels
3 - Ready for Review Ready for review by team Cython / Python Cython or Python issue Multi-GPU Issues & PRs related to multi-GPU functionality New Algorithm For tracking new algorithms that will be added to our existing collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]Distributed TF-IDF Tranformer
5 participants
@VibhuJawa @GPUtester @dantegd @cjnolet @raydouglass