Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] reenable lightgbm test with a lower (1%) proba accuracy threshold #2799

Merged
merged 3 commits into from
Sep 9, 2020
Merged

[REVIEW] reenable lightgbm test with a lower (1%) proba accuracy threshold #2799

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d11c62b
only the proba was wrong, and the error is <1% even on this few colum…
levsnv Sep 4, 2020
bdb8aa5
changelog
levsnv Sep 4, 2020
cbf78dd
Merge branch 'branch-0.16' into reenable-lightgbm-test
dantegd Sep 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
- PR #2783: Add pytest that will fail when GPU IDs in Dask cluster are not unique
- PR #2785: Add in cuML-specific dev conda dependencies
- PR #2778: Add README for FIL
- PR #2799: Reenable lightgbm test with lower (1%) proba accuracy

## Bug Fixes
- PR #2744: Supporting larger number of classes in KNeighborsClassifier
Expand Down
5 changes: 1 addition & 4 deletions python/cuml/test/test_fil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,9 +397,6 @@ def test_output_args(small_classifier_and_preds):
@pytest.mark.skipif(has_lightgbm() is False, reason="need to install lightgbm")
def test_lightgbm(tmp_path):
import lightgbm as lgb
from distutils.version import LooseVersion
if LooseVersion(lgb.__version__) >= LooseVersion('3.0.0'):
pytest.skip('lightgbm version 3 support is underway.')
X, y = simulate_data(500, 10,
random_state=43210,
classification=True)
Expand Down Expand Up @@ -436,4 +433,4 @@ def test_lightgbm(tmp_path):
fil_proba = np.asarray(fm.predict_proba(X))
fil_proba = np.reshape(fil_proba, np.shape(gbm_proba))

assert np.allclose(gbm_proba, fil_proba, 1e-3)
assert np.allclose(gbm_proba, fil_proba, 1e-2)