Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Obey initialize_embeddings parameter in B-H tSNE #3011

Merged
merged 3 commits into from
Oct 21, 2020

Conversation

zbjornson
Copy link
Contributor

Fixes #2549

This is tricky to test with certainty because this t-SNE implementation isn't deterministic, but I'm fairly certain it's correct. The top row of #2980 (comment) uses it.

@zbjornson zbjornson requested a review from a team as a code owner October 16, 2020 23:13
@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

1 similar comment
@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

@codecov-io
Copy link

codecov-io commented Oct 17, 2020

Codecov Report

Merging #3011 into branch-0.17 will increase coverage by 0.56%.
The diff coverage is 96.15%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.17    #3011      +/-   ##
===============================================
+ Coverage        58.39%   58.95%   +0.56%     
===============================================
  Files              143      143              
  Lines             8897     9008     +111     
===============================================
+ Hits              5195     5311     +116     
+ Misses            3702     3697       -5     
Impacted Files Coverage Δ
python/cuml/thirdparty_adapters/adapters.py 88.44% <95.74%> (+6.20%) ⬆️
...l/_thirdparty/sklearn/preprocessing/_imputation.py 62.50% <100.00%> (-4.05%) ⬇️
python/cuml/thirdparty_adapters/__init__.py 100.00% <100.00%> (ø)
python/cuml/pytest_benchmarks/test_bench.py 100.00% <0.00%> (ø)
python/cuml/common/array.py 97.72% <0.00%> (+0.01%) ⬆️
python/cuml/metrics/_ranking.py 98.61% <0.00%> (+0.03%) ⬆️
python/cuml/preprocessing/encoders.py 95.18% <0.00%> (+0.07%) ⬆️
...on/cuml/_thirdparty/sklearn/preprocessing/_data.py 63.45% <0.00%> (+0.12%) ⬆️
python/cuml/naive_bayes/naive_bayes.py 92.69% <0.00%> (+0.16%) ⬆️
...ing/text/stem/porter_stemmer_utils/suffix_utils.py 90.47% <0.00%> (+0.23%) ⬆️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50afa17...01d27eb. Read the comment docs.

@dantegd dantegd added the 3 - Ready for Review Ready for review by team label Oct 19, 2020
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm

@dantegd dantegd added 5 - Ready to Merge Testing and reviews complete, ready to merge CUDA / C++ CUDA issue Cython / Python Cython or Python issue and removed 3 - Ready for Review Ready for review by team labels Oct 19, 2020
@dantegd dantegd merged commit b943d74 into rapidsai:branch-0.17 Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge CUDA / C++ CUDA issue Cython / Python Cython or Python issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Barnes-Hut tSNE does not obey initialize_embeddings param
4 participants