Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Fix gtest pinned cmake version for build from source option [skip-ci] #3175

Merged
merged 2 commits into from
Nov 24, 2020
Merged

[REVIEW] Fix gtest pinned cmake version for build from source option [skip-ci] #3175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1447ed6
FIX Fix gtest pinned cmake version for build from source option
dantegd Nov 23, 2020
f11b1e1
DOC Added entry to changelog
dantegd Nov 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@
- PR #3152: Fix access to attributes of individual NB objects in dask NB
- PR #3156: Force local conda artifact install
- PR #3162: Removing accidentally checked in debug file
- PR #3175: Fix gtest pinned cmake version for build from source option


# cuML 0.16.0 (Date TBD)
Expand Down
2 changes: 1 addition & 1 deletion cpp/cmake/Dependencies.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ if(BUILD_GTEST)
include(ExternalProject)
ExternalProject_Add(googletest
GIT_REPOSITORY https://github.com/google/googletest.git
GIT_TAG 6ce9b98f541b8bcd84c5c5b3483f29a933c4aefb
GIT_TAG release-1.10.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to use the commit SHA rather than the tag? I ask because I've been burned in the past by other projects moving their tags. Don't suspect it would be an issue with gtest, but it seems safer.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I 100% agree with you, I tend to hate tags. But in this case the nice thing is that the tag coincides with the conda package version (and hasn't changed in a year), so I was thinking of doing an exception for this one, what do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! 👍

PREFIX ${GTEST_DIR}
CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=<INSTALL_DIR>
-DBUILD_SHARED_LIBS=OFF
Expand Down