Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Remove previously-replaced metrics.cu file #3179

Merged
merged 2 commits into from
Nov 24, 2020
Merged

[WIP] Remove previously-replaced metrics.cu file #3179

merged 2 commits into from
Nov 24, 2020

Conversation

wphicks
Copy link
Contributor

@wphicks wphicks commented Nov 23, 2020

No description provided.

@wphicks wphicks requested a review from a team as a code owner November 23, 2020 23:01
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@codecov-io
Copy link

codecov-io commented Nov 24, 2020 •
edited
Loading

Codecov Report

Merging #3179 (9c59250) into branch-0.17 (233b770) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.17    #3179   +/-   ##
============================================
  Coverage        70.90%   70.90%           
============================================
  Files              197      197           
  Lines            15682    15682           
============================================
  Hits             11120    11120           
  Misses            4562     4562

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 233b770...9c59250. Read the comment docs.

cjnolet
cjnolet approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet cjnolet added 5 - Ready to Merge Testing and reviews complete, ready to merge CUDA / C++ CUDA issue labels Nov 24, 2020
@cjnolet cjnolet merged commit ae55470 into rapidsai:branch-0.17 Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge CUDA / C++ CUDA issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wphicks @GPUtester @codecov-io @cjnolet