Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] blocks_per_sm FIL parameter in Python. #3180

Merged
merged 5 commits into from
Nov 24, 2020

Conversation

canonizer
Copy link
Contributor

blocks_per_sm FIL parameter in Python.

  • added the parameter and documentation
  • added tests

@canonizer canonizer requested a review from a team as a code owner November 23, 2020 23:07
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@codecov-io
Copy link

codecov-io commented Nov 24, 2020

Codecov Report

Merging #3180 (5ed0d89) into branch-0.17 (e7f6bdf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.17    #3180   +/-   ##
============================================
  Coverage        70.98%   70.99%           
============================================
  Files              198      198           
  Lines            15725    15729    +4     
============================================
+ Hits             11163    11167    +4     
  Misses            4562     4562           
Impacted Files Coverage Δ
python/cuml/fil/fil.pyx 93.75% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7f6bdf...5ed0d89. Read the comment docs.

python/cuml/test/test_fil.py Outdated Show resolved Hide resolved
@JohnZed JohnZed changed the title blocks_per_sm FIL parameter in Python. [REVIEW] blocks_per_sm FIL parameter in Python. Nov 24, 2020
@JohnZed JohnZed merged commit f1abcb8 into rapidsai:branch-0.17 Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants