Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix cuDF to cuPy conversion (missing value) #3194

Merged

Conversation

viclafargue
Copy link
Contributor

Answers #2966 .
This change should probably be implemented in cuDF. In the meantime, I modified the input_to_cupy_array function to produce a proper conversion of cuDF Dataframe and Series to cuPy array even when they contain missing values. The data is upcasted to float64 when necessary.

@viclafargue viclafargue requested a review from a team as a code owner November 26, 2020 14:39
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a couple of questions

python/cuml/common/input_utils.py Outdated Show resolved Hide resolved
python/cuml/common/input_utils.py Outdated Show resolved Hide resolved
python/cuml/common/input_utils.py Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Nov 26, 2020

Codecov Report

Merging #3194 (c674d0a) into branch-0.17 (f1abcb8) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.17    #3194      +/-   ##
===============================================
+ Coverage        70.99%   71.03%   +0.03%     
===============================================
  Files              198      198              
  Lines            15729    15737       +8     
===============================================
+ Hits             11167    11178      +11     
+ Misses            4562     4559       -3     
Impacted Files Coverage Δ
python/cuml/thirdparty_adapters/adapters.py 88.55% <ø> (ø)
python/cuml/common/input_utils.py 93.30% <100.00%> (+0.76%) ⬆️
...hirdparty/sklearn/preprocessing/_discretization.py 85.60% <0.00%> (+1.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1abcb8...c674d0a. Read the comment docs.

python/cuml/common/input_utils.py Outdated Show resolved Hide resolved
Copy link
Contributor

@wphicks wphicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohnZed JohnZed added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants