Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] FIX Fix EXITCODE override in test_notebooks script #3208

Merged
merged 4 commits into from
Dec 1, 2020

Conversation

dillon-cullinan
Copy link
Contributor

@dillon-cullinan dillon-cullinan commented Nov 30, 2020

This script used to override the EXITCODE trap in gpu/build.sh causing failures in anything ran before the notebooks to be missed. Renaming the variable will avoid this problem in the future.

Closes: #3207

@dillon-cullinan dillon-cullinan requested a review from a team as a code owner November 30, 2020 19:04
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

Copy link
Contributor

@JohnZed JohnZed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Nov 30, 2020

Codecov Report

Merging #3208 (5afb4f7) into branch-0.17 (63c8a44) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.17    #3208      +/-   ##
===============================================
- Coverage        70.99%   70.95%   -0.05%     
===============================================
  Files              198      198              
  Lines            15729    15740      +11     
===============================================
+ Hits             11167    11168       +1     
- Misses            4562     4572      +10     
Impacted Files Coverage Δ
python/cuml/dask/neighbors/kneighbors_regressor.py 29.85% <0.00%> (-1.40%) ⬇️
...ython/cuml/dask/neighbors/kneighbors_classifier.py 21.29% <0.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63c8a44...5afb4f7. Read the comment docs.

@JohnZed JohnZed merged commit 9c8dade into rapidsai:branch-0.17 Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] CI incorrectly marks failing test as passed
6 participants