Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Add xfail on fetching 20newsgroup dataset (test_naive_bayes) #3291

Merged
merged 2 commits into from
Dec 14, 2020

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Dec 10, 2020

This PR fixes CI fails that happen on test_naive_bayes when the machine can't download the 20 newsgroup dataset.

It closes #3260

@lowener lowener requested a review from a team as a code owner December 10, 2020 15:51
@JohnZed JohnZed added bug Something isn't working non-breaking Non-breaking change labels Dec 10, 2020
@codecov-io
Copy link

Codecov Report

Merging #3291 (f892546) into branch-0.18 (62e2152) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.18    #3291   +/-   ##
============================================
  Coverage        71.28%   71.28%           
============================================
  Files              206      206           
  Lines            16621    16621           
============================================
  Hits             11848    11848           
  Misses            4773     4773           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62e2152...f892546. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 34efaf8 into rapidsai:branch-0.18 Dec 14, 2020
@lowener lowener deleted the 018_fix_naive_bayes_test branch January 10, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] test_naive_bayes should use local data / not download
3 participants