-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Added ability to call cuML with numpy arrays and general test cleaning #33
Conversation
@@ -185,7 +179,7 @@ class PCA: | |||
def _get_column_ptr(self, obj): | |||
return self._get_ctype_ptr(obj._column._data.to_gpu_array()) | |||
|
|||
def fit(self, X, _transform=True): | |||
def fit(self, X, _transform=False): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to return self in fit to comply with sklearn like api
@dantegd Just tested and it worked for me. Great work! Quick question. Can we add these numpy examples in the jupyter notebooks? I think people will like to see these code examples. Maybe Jiwei can help on this. Any thoughts? |
PR adds the ability to call cuML methods using numpy arrays (except for knn for now):
Also major cleaning of the python tests and expanded coverage. Upcoming PR will clean and improve kmeans, and overall improve coverage.
Also solves bugs dbscan and other methods.