Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dbscan refactor #35

Merged
merged 7 commits into from
Nov 15, 2018
Merged

Dbscan refactor #35

merged 7 commits into from
Nov 15, 2018

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Nov 15, 2018

  • Remove utils.h and direct files to use cuda_utils.h from ml_prims
  • Fix tests (there were comments in the vertexdeg's runner.h causing tests of algo5 to fail.

dantegd
dantegd approved these changes Nov 15, 2018
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks great and fixes the dbscan tests, thanks @cjnolet

@dantegd dantegd merged commit bd2ea83 into rapidsai:master Nov 15, 2018
This was referenced Nov 16, 2018
Merged
Closed
@JasonAtNvidia JasonAtNvidia mentioned this pull request Jan 27, 2020
Closed
@hershkoy hershkoy mentioned this pull request Jul 15, 2020
Open
@tkpudgy tkpudgy mentioned this pull request Jul 29, 2021
Closed
@VibhuJawa VibhuJawa mentioned this pull request Jan 13, 2022
Open
@seo-jaeyong seo-jaeyong mentioned this pull request Jul 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjnolet @dantegd