-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove xfail for KBinsDiscretizer quantile tests #3804
Remove xfail for KBinsDiscretizer quantile tests #3804
Conversation
Following the update to cupy 8.5.0, the bad read in the `cupy.percentile` kernel should no longer be an issue, allowing us to remove the xfail on this test. Close rapidsai#2933
@wphicks I know that this might be overkill, but do you think it'd be a good idea to run the test a large number of times locally, though a CI run that only runs that test a number of times might be good too, be a good idea? |
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #3804 +/- ##
==============================================
Coverage ? 86.04%
==============================================
Files ? 225
Lines ? 17113
Branches ? 0
==============================================
Hits ? 14725
Misses ? 2388
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
I don't mind doing that again if it would give us more confidence in this, but as I was initially investigating #3481, I ran this some huge number of times (tens of thousands maybe?) without seeing a failure. I also have a fair amount of confidence that we found the root cause on this one, though it's always possible that I'm wrong. Want me to spin up another run overnight, or do we feel good enough with that level of testing? |
I think that level of testing is good, I had forgotten the journey of the bug a little bit, so will go ahead and merge |
@gpucibot merge |
Following the update to cupy 8.5.0, the bad read in the `cupy.percentile` kernel should no longer be an issue, allowing us to remove the xfail on this test. Close rapidsai#2933 Authors: - William Hicks (https://github.com/wphicks) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#3804
Following the update to cupy 8.5.0, the bad read in the
cupy.percentile
kernel should no longer be an issue, allowing us to remove the xfail on this test.Close #2933