Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAPML-100: update CMakeLists.txt #39

Merged
merged 1 commit into from
Nov 28, 2018

Conversation

burlachenkok
Copy link
Contributor

@burlachenkok burlachenkok commented Nov 28, 2018

What I proposed

  1. make some minor updates with CMakeLists.txt in README.md
  2. fixup: correct way to link with different CUDA libraries in project files. How it is done currently is nor correct.
  3. fixup: make project buildable when from C++ source files CUDA Runtime is using. CUDA runtime just have been forgotten to be linked.
  4. Instead enumerate source files by hands for compile target - just use wildcard glob expression to include them in compile target.

Only one reason why project is buildable is that currently all source files has cuda extension and go through nvcc CUDA compiler and 2,3 is well-defined thing for him

@dantegd
Copy link
Member

dantegd commented Nov 28, 2018

Hi @burlachenkok , could you provide a description and more descriptive title of what the PR accomplishes to ease review? Thanks!

@burlachenkok
Copy link
Contributor Author

Hi @dantegd done.

Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, and tests pass without issues I can see. Just one small question about addition to README.md

README.md Show resolved Hide resolved
@dantegd
Copy link
Member

dantegd commented Nov 28, 2018

Merging, thanks @burlachenkok !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants