Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nested include in destination of install headers to avoid docker permission issues #3962

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Use nested include in destination of install headers to avoid docker permission issues #3962

merged 1 commit into from
Jun 24, 2021

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Jun 8, 2021

No description provided.

@dantegd dantegd added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Jun 8, 2021
@dantegd dantegd requested a review from a team as a code owner June 8, 2021 16:57
@dantegd dantegd added the ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround label Jun 9, 2021
@dantegd dantegd changed the base branch from branch-21.06 to branch-21.08 June 10, 2021 20:29
@dantegd dantegd removed the ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround label Jun 10, 2021
@dantegd
Copy link
Member Author

dantegd commented Jun 17, 2021

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@19e9699). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #3962   +/-   ##
===============================================
  Coverage                ?   85.63%           
===============================================
  Files                   ?      230           
  Lines                   ?    18892           
  Branches                ?        0           
===============================================
  Hits                    ?    16178           
  Misses                  ?     2714           
  Partials                ?        0
Flag Coverage Δ
dask 48.92% <0.00%> (?)
non-dask 78.06% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19e9699...880fa02. Read the comment docs.

@dantegd
Copy link
Member Author

dantegd commented Jun 24, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 76e6b51 into rapidsai:branch-21.08 Jun 24, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@dantegd
Use nested include in destination of install headers to avoid docker …
cffe931 
…permission issues (rapidsai#3962)

Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)

URL: rapidsai#3962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working CMake CUDA/C++ non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dantegd @codecov-commenter @robertmaynard