Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dask/Distributed version #3978

Merged
merged 3 commits into from
Jun 14, 2021
Merged

Update Dask/Distributed version #3978

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6fb00fb
Install Dask/Distributed main in CI
pentschev Jun 10, 2021
e541896
Install Dask/Distributed 2021.6.0 in conda environments
pentschev Jun 10, 2021
80c340d
Use Dask/Distributed main in conda dev environments
pentschev Jun 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ci/gpu/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,8 @@ if [[ -z "$PROJECT_FLASH" || "$PROJECT_FLASH" == "0" ]]; then

gpuci_logger "Install the main version of dask and distributed"
set -x
pip install "git+https://github.com/dask/distributed.git@2021.05.1" --upgrade --no-deps
pip install "git+https://github.com/dask/dask.git@2021.05.1" --upgrade --no-deps
pip install "git+https://github.com/dask/distributed.git@main" --upgrade --no-deps
pip install "git+https://github.com/dask/dask.git@main" --upgrade --no-deps
set +x

gpuci_logger "Python pytest for cuml"
Expand Down
4 changes: 2 additions & 2 deletions conda/environments/cuml_dev_cuda11.0.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ dependencies:
- libcumlprims=21.08.*
- dask-cudf=21.08.*
- dask-cuda=21.08.*
- dask>=2021.6.0
- distributed>=2021.6.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change from installing from main? Since CI is installing from main, we should keep this so dev environments behave like CI (and mirror cudf https://github.com/rapidsai/cudf/blob/0a4e8a1c860518c9e30f5289dea07bd0879fb642/conda/environments/cudf_dev_cuda11.2.yml#L64)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's still done above. Peter is just setting a minimum version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think what Dante was asking for is that the conda dev environment files install Dask/Distributed main to match the same as CI is running on. I did that in 80c340d now.

- ucx-py=0.21
- ucx-proc=*=gpu
- dask-ml
Expand All @@ -26,8 +28,6 @@ dependencies:
- pip
- pip:
- sphinx_markdown_tables
- git+https://github.com/dask/dask.git@2021.05.1
- git+https://github.com/dask/distributed.git@2021.05.1

# rapids-build-env, notebook-env and doc-env are defined in
# https://docs.rapids.ai/maintainers/depmgmt/
Expand Down
4 changes: 2 additions & 2 deletions conda/environments/cuml_dev_cuda11.2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ dependencies:
- libcumlprims=21.08.*
- dask-cudf=21.08.*
- dask-cuda=21.08.*
- dask>=2021.6.0
- distributed>=2021.6.0
- ucx-py=0.21
- ucx-proc=*=gpu
- dask-ml
Expand All @@ -26,8 +28,6 @@ dependencies:
- pip
- pip:
- sphinx_markdown_tables
- git+https://github.com/dask/dask.git@2021.05.1
- git+https://github.com/dask/distributed.git@2021.05.1

# rapids-build-env, notebook-env and doc-env are defined in
# https://docs.rapids.ai/maintainers/depmgmt/
Expand Down