Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing extract clusters in HDBSCAN #4009

Merged
merged 7 commits into from
Jul 9, 2021
Merged

Testing extract clusters in HDBSCAN #4009

merged 7 commits into from
Jul 9, 2021

Conversation

divyegala
Copy link
Member

No description provided.

@divyegala divyegala requested review from a team as code owners June 23, 2021 17:37
@github-actions github-actions bot added CUDA/C++ Cython / Python Cython or Python issue labels Jun 23, 2021
@divyegala divyegala added CUDA / C++ CUDA issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change tests Unit testing for project and removed CUDA/C++ labels Jun 23, 2021
@divyegala divyegala mentioned this pull request Jun 23, 2021
Open
21 tasks
cjnolet
cjnolet requested changes Jul 8, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The impl itself to expose the extract clusters function looks good. Just hoping to see nonzero cluster_selection_epsilon tested in the last pytest so we can check that off of our list.

python/cuml/test/test_hdbscan.py Outdated Show resolved Hide resolved
@divyegala divyegala requested a review from cjnolet July 9, 2021 18:30
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@f654048). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #4009   +/-   ##
===============================================
  Coverage                ?   85.41%           
===============================================
  Files                   ?      230           
  Lines                   ?    18050           
  Branches                ?        0           
===============================================
  Hits                    ?    15417           
  Misses                  ?     2633           
  Partials                ?        0
Flag Coverage Δ
dask 47.80% <0.00%> (?)
non-dask 77.66% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f654048...3ebde5c. Read the comment docs.

cjnolet
cjnolet approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet
Copy link
Member

cjnolet commented Jul 9, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 964f40e into rapidsai:branch-21.08 Jul 9, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@divyegala
Testing extract clusters in HDBSCAN (rapidsai#4009)
0b0c124 
Authors:
  - Divye Gala (https://github.com/divyegala)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
CUDA / C++ CUDA issue CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change tests Unit testing for project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@divyegala @codecov-commenter @cjnolet