Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable installing gbench to avoid container permission issues #4049

Merged
merged 3 commits into from
Jul 15, 2021
Merged

Disable installing gbench to avoid container permission issues #4049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c06e6b7
ENH Disable installing gbench to avoid container permission issues
dantegd Jul 13, 2021
4bfc9fb
FIX Remove unnecessary link
dantegd Jul 13, 2021
e31181e
FIX undo linking change
dantegd Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/bench/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ if(BUILD_CUML_BENCH)

target_link_libraries(${CUML_CPP_BENCH_TARGET}
PUBLIC
cuml
cuml::${CUML_CPP_TARGET}
benchmark::benchmark
raft::raft
$<IF:$<BOOL:${Treelite_ADDED}>,treelite::treelite_static,treelite::treelite>
Expand Down
3 changes: 1 addition & 2 deletions cpp/cmake/thirdparty/get_gbench.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,9 @@ function(find_and_configure_gbench)
OPTIONS
"BENCHMARK_ENABLE_GTEST_TESTS OFF"
"BENCHMARK_ENABLE_TESTING OFF"
"CMAKE_INSTALL_PREFIX <INSTALL_DIR>"
"BENCHMARK_ENABLE_INSTALL OFF"
"CMAKE_BUILD_TYPE Release"
"CMAKE_INSTALL_LIBDIR lib"
# BUILD_BYPRODUCTS ${benchmark_BINARY_DIR}/lib/libbenchmark.a
)

if(NOT TARGET benchmark::benchmark)
Expand Down