[REVIEW] Minimal fix for SparseRandomProjection
#4100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viclafargue
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #4100 +/- ##
===============================================
Coverage ? 85.77%
===============================================
Files ? 231
Lines ? 18261
Branches ? 0
===============================================
Hits ? 15664
Misses ? 2597
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
dantegd
approved these changes
Jul 27, 2021
|
@gpucibot merge |
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
Answers rapidsai#3857 This PR directly fixes the issue described in rapidsai#3857. Further updates to the `SparseRandomProjection` model will be merged from rapidsai#3899 once RAPIDS will drop CentOS7 support in favor of CentOS8. Authors: - Victor Lafargue (https://github.com/viclafargue) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Answers #3857
This PR directly fixes the issue described in #3857. Further updates to the
SparseRandomProjectionmodel will be merged from #3899 once RAPIDS will drop CentOS7 support in favor of CentOS8.